observablehq / framework

A static site generator for data apps, dashboards, reports, and more. Observable Framework combines JavaScript on the front-end for interactive graphics with any language on the back-end for data analysis.
https://observablehq.com/framework/
ISC License
2.41k stars 111 forks source link

Don't use the login flow for tests that aren't testing login #1400

Closed mythmon closed 4 months ago

mythmon commented 4 months ago

While reviewing #1399, I was surprised the test hit used loginInner at all, because it wasn't testing the login flow. I changed the tests to start with an API key, instead of needing to pretend to get one from logging in.

This won't change what the test is testing or it's speed much, but it makes it a smaller, more focused test that only works on what it says it is doing.