observablehq / framework

A static site generator for data apps, dashboards, reports, and more. Observable Framework combines JavaScript on the front-end for interactive graphics with any language on the back-end for data analysis.
https://observablehq.com/framework/
ISC License
2.58k stars 125 forks source link

Update types #1695

Closed mootari closed 1 month ago

mootari commented 1 month ago

A typo in an outdated markdown-it type made me notice that several of our types don't match their library versions.

This PR

Some notes:

mootari commented 1 month ago

How about dropping the test but keeping the rest of the changes?

Sure, it didn't feel quite right anyway. 🙂

I also updated the Node types to match the minimum engine version.

mbostock commented 1 month ago

Did this PR introduce this warning? We should fix…

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.2

Please only submit bug reports when using the officially supported version.

=============
mootari commented 1 month ago

@mbostock No, by #957 as far as I can tell. We may need to update eslint I think?

mbostock commented 1 month ago

Thanks for tracking that down @mootari!