rounded rect - Githubissues

observablehq / plot

A concise API for exploratory data visualization implementing a layered grammar of graphics

https://observablehq.com/plot/

ISC License

4.16k stars 171 forks source link

rounded rect #2099

Closed mbostock closed 1 week ago

mbostock commented 2 weeks ago

TODO

[x] rect
[x] bar & cell
[x] frame
[x] r option
[x] handle inverted orientations
[x] handle corner radii that are too big
[x] treat negative or invalid radii as zero
[x] handle insets
[x] handle missing channels
[x] handle collapsed channels
[x] handle projections
[x] allow larger corners if asymmetric
[x] consolidate code between rect, bar, and cell
[x] optimize conditionals?
[x] documentation
[x] tests

Fixes #2054.

mbostock commented 2 weeks ago

The implementation is now feature-complete and I’d welcome testing or feedback. I might try to optimize the conditionals, and add more documentation, before marking this as ready.

mbostock commented 1 week ago

I believe this is documented and ready for review. PTAL @Fil!