observatorium / obsctl

A cli to interact with Observatorium instances.
Apache License 2.0
10 stars 14 forks source link

Add rm context command #30

Closed jessicalins closed 2 years ago

jessicalins commented 2 years ago

I thought would be nice to have a command that removes the context, without the need to individually remove tenant and/or api. This PR adds the following behavior:

If we agree on this behavior, I'd then add tests + update docs :) It partially implements https://github.com/observatorium/obsctl/issues/23

Signed-off-by: Jéssica Lins jessicaalins@gmail.com

douglascamata commented 2 years ago

It removes a tenant from an api. If the api has only one tenant, the whole api is removed

I think there has to be some extra care when writing documentation and talking about this. With this sentence, some may understand that there is an API in Observatorium to manage tenants and that obsctl can interact with it to add/remove tenants... which is not the case.

jessicalins commented 2 years ago

@saswatamcode @douglascamata thanks for the review! I've added test + modified the docs. I think we can improve docs in another pr (related issue: https://github.com/observatorium/obsctl/issues/28)