Improve response and error printing for metrics subcommands - Githubissues

observatorium / obsctl

A cli to interact with Observatorium instances.

Apache License 2.0

10 stars 14 forks source link

Improve response and error printing for metrics subcommands #34

Closed matej-g closed 2 years ago

matej-g commented 2 years ago

Signed-off-by: Matej Gera matejgera@gmail.com

This PR provides a couple of suggested improvements for handling metrics responses:

Better response parsing: Handle properly also non-JSON responses (as currently error messages are not returned in JSON - see https://github.com/observatorium/api/issues/319)
Do not print usage message on response errors for metrics sub-commands
Minor refactoring