Workaround for efficientgo/e2e dependency issue

observatorium / obsctl

A cli to interact with Observatorium instances.

Apache License 2.0

10 stars 14 forks source link

Workaround for efficientgo/e2e dependency issue #39

Closed mmazur closed 4 months ago

mmazur commented 2 years ago

There's an issue with one of the dependencies that makes obsctl not build out of the box (details: efficientgo/e2e#41). This change is a workaround for the upstream issue until that gets fixed and trickles down to obsctl.

matej-g commented 2 years ago

Hey @mmazur, strange but I'm unable to reproduce this in any way. How are you building obsctl?

mmazur commented 2 years ago

Without this change this is what I get:

[mmazur@klapek obsctl]$ make build
go: github.com/efficientgo/e2e@v0.12.0 requires
        github.com/efficientgo/tools/core@v0.0.0-20210129205121-421d0828c9a6: invalid version: unknown revision 421d0828c9a6
make: *** [Makefile:54: deps] Błąd 1

And with it:

[mmazur@klapek obsctl]$ make build
all modules verified
>> building obsctl

saswatamcode commented 2 years ago

Hmm, I also cannot seem to replicate this.

mmazur commented 2 years ago

Golang's build dep errors are a never-ending source of mystery for me, so I can't offer an explanation on this would happen on my system and not on other peoples'.

Though I'm clearly not the only person that's encountered this based on @bwplotka's case thanos-io/thanos#4806 from late last year.

matej-g commented 2 years ago

Is still persisting for you @mmazur? I was fixing this on the linked issue in Thanos, however IIRC back then the failed builds were reproducible by multiple people.

saswatamcode commented 2 years ago

Would love to know what OS + go ver you're building on @mmazur! Maybe we're missing something here! 🙂

mmazur commented 2 years ago

Install a fresh fedora 36 (go version go1.18.3 linux/amd64) in a VM and you should be able to reproduce this. I've just checked make build on a fresh fedora 36 install from 7 weeks ago that I haven't used for anything yet (had to dnf install golang-bin just to test it) and got the exact same error.

saswatamcode commented 2 years ago

Sorry for the delay here, but I could also replicate this in a VM with dnf install golang-bin. But nowhere else, so I'm a bit confused about why a certain dep would only fail in such an env. 🤔 Will test this out some more and update here @mmazur!

nvinzens commented 2 years ago

I'm seeing the same when trying to build inside a docker container based on quay.io/prometheus/golang-builder:1.17-base.