search

observatorium / obsctl

A cli to interact with Observatorium instances.
Apache License 2.0
10 stars 14 forks source link

feat: make oidc scopes configurable #49

Closed RaphaelBut closed 1 year ago

RaphaelBut commented 1 year ago

Small change to make the scopes that are requested during login configurable per new flag 'oidc.scopes'.

Why: Service accounts without offline_access capabilities are unable to log in due to requesting offline_access without permissions. With this override one can omit 'offline_access' if required.

I kept the hardcoded values 'openid' and 'offline_access' as defaults on the flag to not introduce any breaking changes.

saswatamcode commented 1 year ago

The test failures seem to be related to log changes and not related. Let's merge and iterate on those.