search

observatorium / opentelemetry-collector-builder

A CLI tool that generates OpenTelemetry Collector binaries based on a manifest.
Apache License 2.0
21 stars 2 forks source link

Mac releases after 0.1.1 are not working #30

Open kevinearls opened 3 years ago

kevinearls commented 3 years ago

I've downloaded all versions of the collector-builder from the releases page on my. None of them work after version 0.1.1. When I attempt to run them I just get "Killed: 9"

jpkrohling commented 3 years ago

I don't have a Mac, would you be able to run the builder locally from the sources and test? If it fails, could you run a git bisect and see if the problem is in something we are doing? If go get works, it might mean that the problem is in the packaging process.

kevinearls commented 3 years ago

Sure. How do I build though? I thought of that yesterday but didn't find instructions anywhere

jpkrohling commented 3 years ago

go run should do it

kevinearls commented 3 years ago

go run main.go works fine, as does go build main.go and running the executable it creates.

jpkrohling commented 3 years ago

Could you go over the goreleaser and see if you can reproduce it? Or perhaps check the release logs and see if anything seems suspicious? One thing that could be broken is the upx command, to compact the binary.

kevinearls commented 3 years ago

I installed goreleasor and upx on my mac and everything worked fine. (I actually built twice, once without upx installed so I could verify uncompressed builds.)

The difference may be that I used brew to install upx and that got me version 3.96 whereas we are getting 3.94 from the github action. I couldn't verify this completely as there is no 3.94 version of upx available via brew, and upx does not have darwin versions on their releases page.

jpkrohling commented 3 years ago

Can you send a PR removing upx? We can then check whether that's the problem once we release the next version

jpkrohling commented 3 years ago

Releasing 0.4.1 with #31

kevinearls commented 3 years ago

@jpkrohling The mac download now works

jpkrohling commented 3 years ago

It was indeed upx then. There's a list of all the software used by Github workers by version of the operating system. If we are using ubuntu-latest, it might really be the latest yet (20-04?). At least until recently, latest pointed to 18.04.