search

observatorium / thanos-receive-controller

Kubernetes controller to automatically configure Thanos receive hashrings
Apache License 2.0
96 stars 46 forks source link

Support Multi-AZ in HashRing Config #127

Closed christopherzli closed 6 months ago

christopherzli commented 10 months ago

As thanos support az aware hashring config starting from v0.32: https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental, we should support multi az in the controller to update config as well.

christopherzli commented 10 months ago

pull request here: https://github.com/observatorium/thanos-receive-controller/pull/129

algo7 commented 7 months ago

This would appreciated. At the moment it seems to not support Ketama AZ-aware hashring as mentioned in Thanos official documentation here: https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental

Using the config provided in Thanos doc results in the controller throwing error

level=warn caller=main.go:547 ts=2024-05-01T04:56:39.561782951Z msg="failed to decode configuration" err="json: cannot unmarshal object into Go struct field HashringConfig.endpoints of type string"
christopherzli commented 7 months ago

thanks @algo7 , hope this PR could be reviewed soon 😄

christopherzli commented 6 months ago

PR merged 😄