search

observatorium / thanos-receive-controller

Kubernetes controller to automatically configure Thanos receive hashrings
Apache License 2.0
93 stars 42 forks source link

Add alerts and dashboards #25

Closed kakkoyun closed 4 years ago

kakkoyun commented 4 years ago

cc @squat

squat commented 4 years ago

Can you re-commit this without adding the jsonnet/vendor dir? normally we expect that to be generated by jb with the lockfile, so there's no need to commit it to the repo

kakkoyun commented 4 years ago

cc @metalmatze

brancz commented 4 years ago

Why are we committing a lockfile here at all?

squat commented 4 years ago

ah, frederic means that since this repo doesnt actually commit any generated manifests, i.e. it is only used as a library that is imported by other jsonnet projects, it doesn't need to lock and dependencies.

kakkoyun commented 4 years ago

@brancz for no particular reason, I didn't know we shouldn't. I'll remove it.

kakkoyun commented 4 years ago

@squat Got that now 👍 Thanks for the explanation :)

brancz commented 4 years ago

lgtm, leaving last call to @squat @metalmatze

kakkoyun commented 4 years ago

@squat I have fixed emphasized make issues. I introduced two new docker images as drone stages https://github.com/kakkoyun/docker-go-promtool and https://github.com/kakkoyun/docker-go-jsonnet-ci. I can put them some other common registry, I've just put them in my personal account for now.

squat commented 4 years ago

To simplify the maintenance of docker containers, I think we should use the quay.io/coreos/jsonnet-ci container. We use this in several other projects (prometheus-operator, CMO, telemeter etc). The only thing it is missing is promtool, so we'd have to add that. This way you don't need to build and keep the other two containers up to date. WDYT?

kakkoyun commented 4 years ago

@squat Totally makes sense. I'll send a PR to add promtool. I guess this is the place https://github.com/coreos/prometheus-operator/blob/master/scripts/jsonnet/Dockerfile

brancz commented 4 years ago

We can move forward here now, the image is about to be published.

kakkoyun commented 4 years ago

@squat quay.io/coreos/jsonnet-ci is updated as we talked https://github.com/coreos/prometheus-operator/pull/2739. It's merged and this PR updated. Ready for your review.

brancz commented 4 years ago

lgtm giving @squat last call