search

observatorium / thanos-receive-controller

Kubernetes controller to automatically configure Thanos receive hashrings
Apache License 2.0
93 stars 42 forks source link

*: Refactor to not mutate global objects #39

Closed brancz closed 4 years ago

brancz commented 4 years ago

Same kind of refactoring as https://github.com/thanos-io/kube-thanos/pull/90.

@squat @bwplotka @metalmatze @kakkoyun @krasi-georgiev

metalmatze commented 4 years ago

Looking really good. :) The ThanosReceiveController might be a good candidate to experiment with using plain Jsonnet objects as base line. Like writing the ServiceAccount without ksonnet and other components. We could do that in a follow up though, if we would want to try that.

brancz commented 4 years ago

Agreed :100: .

squat commented 4 years ago

Just one comment, otherwise looks great to me :)