search

observatorium / thanos-receive-controller

Kubernetes controller to automatically configure Thanos receive hashrings
Apache License 2.0
93 stars 42 forks source link

Make lint fails on master #46

Closed rollandf closed 2 years ago

rollandf commented 4 years ago

commit 11e63ca1d3b9834e66ee85107df002bde29a4a59

main.go:90:2: assignments should only be cuddled with other assignments (wsl)
main.go:173:2: if statements should only be cuddled with assignments (wsl)
main.go:244:2: if statements should only be cuddled with assignments used in the if statement itself (wsl)
main.go:255:2: return statements should not be cuddled if block has more than two lines (wsl)
main.go:411:2: go statements can only invoke functions assigned on line above (wsl)
main.go:412:2: if statements should only be cuddled with assignments (wsl)
main.go:415:2: expressions should not be cuddled with blocks (wsl)
main.go:425:2: only one cuddle assignment allowed before go statement (wsl)
main.go:428:2: return statements should not be cuddled if block has more than two lines (wsl)
main.go:444:4: assignments should only be cuddled with other assignments (wsl)
main.go:441:2: only one cuddle assignment allowed before range statement (wsl)
main.go:449:2: if statements should only be cuddled with assignments (wsl)
main.go:452:2: expressions should not be cuddled with blocks (wsl)
main.go:453:2: return statements should not be cuddled if block has more than two lines (wsl)
main.go:465:2: only one cuddle assignment allowed before if statement (wsl)
main.go:470:2: assignments should only be cuddled with other assignments (wsl)
main.go:483:3: only one cuddle assignment allowed before if statement (wsl)
main.go:480:2: ranges should only be cuddled with assignments used in the iteration (wsl)
main.go:545:3: expressions should not be cuddled with blocks (wsl)
main.go:539:2: only one cuddle assignment allowed before if statement (wsl)
main.go:572:2: declarations should never be cuddled (wsl)
main.go:573:2: expressions should not be cuddled with declarations or returns (wsl)
main_test.go:194:3: only cuddled expressions if assigning variable or using from line above (wsl)
main_test.go:271:3: only cuddled expressions if assigning variable or using from line above (wsl
brancz commented 4 years ago

I've encountered this before as well. We need to pin the version used.