search

observatorium / thanos-receive-controller

Kubernetes controller to automatically configure Thanos receive hashrings
Apache License 2.0
96 stars 46 forks source link

when clustername is empty remove extra dot in endpoints #63

Closed jmichalek132 closed 3 years ago

jmichalek132 commented 3 years ago

Hi, in my case endpoints cannot contain clusterName. Without this change there is extra dot after svc. Would you be willing to accept this change?

Thank you.

jmichalek132 commented 3 years ago

I gave up the linter wins.

bwplotka commented 3 years ago

For lint go mod tidy should help

jmichalek132 commented 3 years ago

Not sure why the test TestController/OneHashringManyStatefulSets failed after I added the new one. When I ran the test locally they succeed.