observerss / pygodaddy

3rd Party Client Library for Manipulating Go Daddy DNS Records.
https://pygodaddy.readthedocs.org/
Other
37 stars 30 forks source link

Fixed for new Login Mechinism #14

Open ghost opened 9 years ago

ghost commented 9 years ago

GoDaddy updated their login mechanism, hasn't been working since 24th August 2015, I have updated pygodaddy to allow logins to work again.

AndreasLoow commented 9 years ago

This crashes with

Traceback (most recent call last):
  [...]
  File "[...]/pygodaddy/__init__.py", line 1, in <module>
    from .client import GoDaddyClient, GoDaddyAccount, LoginError
  File "[...]/pygodaddy/client.py", line 108
    loginUri = 'https://sso.godaddy.com/v1/?path=%2Fdefault.aspx&app=mya&regionsite=au&marketid=en-AU'
                                                                                                     ^
TabError: inconsistent use of tabs and spaces in indentation

for me (using 3.4.3). #13 works however.

andresvidal commented 9 years ago

Any idea when these are getting merged?

ghost commented 9 years ago

@AndreasLoow I've been using this code since I put it up here and it's working fine, might be the way I copied it to github from my terminal, however 2 other people said it was working for them so I'm not sure what went wrong for you. #13 is just my code that claneys pulled and made a few changes to, I just hadn't made a pull request.

AndreasLoow commented 9 years ago

@BryceGough: The problem, as the stack trace in my previous comment says, is that you mix tabs and spaces when indenting your code. But #13 is better anway, imho, as it does not contain irrelevant changes.

pretyman commented 8 years ago

@AndreasLoow agreed, https://github.com/observerss/pygodaddy/pull/13 seems to have less changes and does the job

xMAC94x commented 8 years ago

13 worked for me too.

I installed it directly from claneys via

pip install --upgrade git+git://github.com/claneys/pygodaddy.git

and upgraded to python3 (but i dont know if this was necessary)