Closed AdriVanHoudt closed 9 years ago
@3rd-Eden what are your thoughts on moving to Lab? And are those empty it()
's tests that need to be made?
@AdriVanHoudt Not fan of lab and I don't see any benefits for it for this this library. And yes, the empty it's are placeholders for tests that still need to be written.
@3rd-Eden can I ask you why not? and what should those tests include? maybe I can help
@3rd-Eden I'll do a PR with lab implemented and then we can discuss it there, still interested in your opinion on why not to go with lab though
First of all, thanks for the nice contributions, I'd rather not move to lab either. Most of the observing modules are using assume/expect/mocha and I'd like to keep it that way. This reduces external dependencies.
Also I'm wondering what the thoughts behind changing https://github.com/observing/fullcontact/pull/10/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R18 are? I've learned not to trust developers to correctly follow semver ;) and generally tend to be really defensive with it. Minor bumps usually (although they shouldn't) break stuff.
@3rd-Eden
I'll make the PR and close it immediately, if you want take a look and otherwise it's there for reference so I don't lose it by accident.
if
+
e.g.var a = '' + 'test'
instead ofvar a = ''+ 'test'
var
's to declare variablesWhat I still want to do is rework the tests to not use
it()
for logging stuff, it says now that 18 tests are pending. Or are these tests that need to be made yet? And maybe update the docs to include the webhook stuff.Also I don't know if mocha can do this but Lab(my go to test lib) can do linting and can even make the tests fail if there are linting errors. And it can be configured to look like mocha. If you want this I'll be happy to replace it.
I will also use this as my base for implementing the company api (sorry I couldn't do that sooner) so we can either merge this or just the full thing later. If you have any remarks please feel free. @observing/full-contact-write