Update dep to remove warn about cross-spaw

observing / pre-commit

Automatically installs a git pre-commit script in your git repository which runs your `npm test` on pre-commit

MIT License

1.88k stars 152 forks source link

Update dep to remove warn about cross-spaw #76

Closed luanmuniz closed 8 years ago

luanmuniz commented 8 years ago

With this the following warn is fixed

npm WARN deprecated cross-spawn-async@2.2.4: cross-spawn no longer requires a build toolchain, use it instead!

coveralls commented 8 years ago

Coverage remained the same at 95.413% when pulling 33f02736431d64a59aa16c41b28ae6a14ad8bdaa on luanmuniz:master into fec48cb4e642dfcd62bbdae144f2496a4e43fd0f on observing:master.

3rd-Eden commented 8 years ago

Error: In order to use spawnSync on node 0.10 or older, you must install spawn-sync

So it needs to have the spawn-sync module installed as well in order to not break backwards compatibility.

luanmuniz commented 8 years ago

Is there any interest in doing this after the TLS for 0.10 and 0.12 ends?

3rd-Eden commented 8 years ago

Well all that is needed is to add spawn-sync to the dependencies and it should just pass the tests again.

coveralls commented 8 years ago

Coverage remained the same at 95.413% when pulling 58a4511bc98b7efd80fe88bc94ad60a11986df44 on luanmuniz:master into fec48cb4e642dfcd62bbdae144f2496a4e43fd0f on observing:master.

luanmuniz commented 8 years ago

@3rd-Eden You are right, sorry. i was reading the name of this module and thinking on another. Just added the dependence.

coveralls commented 8 years ago

Coverage remained the same at 95.413% when pulling 69e8b0e2196267b1a7c6c59bb6155f4d255d5a2c on luanmuniz:master into fec48cb4e642dfcd62bbdae144f2496a4e43fd0f on observing:master.

coveralls commented 8 years ago

Coverage remained the same at 95.413% when pulling 69e8b0e2196267b1a7c6c59bb6155f4d255d5a2c on luanmuniz:master into fec48cb4e642dfcd62bbdae144f2496a4e43fd0f on observing:master.

3rd-Eden commented 8 years ago

Thanks for your contribution :)