Closed barroudjo closed 7 years ago
How does the pre-commit
file update on changes made inside of package.json
?
It doesn't update the pre-commit file, and it didn't either before this pull request. In both cases the pre-commit hook (directly before, indirectly with this pull request) launches the JS script from this module, which itself launches the scripts defined in the "pre-commit" section of your package.json.
Duh yeah okay makes plenty of sense, thanks for the clarification.
Can the committers please take a look ? This will make life easier for a lot of people.
👍 Could really do with a working solution on windows
I very much need this as well, could this be looked at ?
It's in master, can other windows users confirm that it's working for them? Once I get a few +1's i'll release it.
Hey sorry it took so long to get back to you. Just tested master on windows and its working for me now!
@3rd-Eden Any idea when release might be?
On my mac, it looks like the pre-commit file generated is not executable, so the hook isn't firing. Anyone else have this issue? Maybe need to specify mode in options here? https://github.com/observing/pre-commit/pull/84/files#diff-f16acefe4b6553580c43edab685f50f3R68
Instead of symlinking to the hook in node-modules/pre-commit, this injects a new pre-commit hook (in .git/hooks) that takes care of launching the hook in node-modules/pre-commit. This avoids the whole hassle with symlink creation in windows, which up to now prevented using this module when users could not gain elevated privileges (very frequent in enterprise environments).