Enable support for space-separated command chains - Githubissues

observing / pre-commit

Automatically installs a git pre-commit script in your git repository which runs your `npm test` on pre-commit

MIT License

1.88k stars 150 forks source link

Enable support for space-separated command chains #91

Closed FabianMeul closed 7 months ago

FabianMeul commented 7 years ago

When using external scripts such as Package-Scripts, we need to provide the command chain as a space-separated string. (e.g. npm start lint-scripts)

To support that kind of syntax, I've added some logic that a space-separated string is spread as separate properties in the spawn array.

This does not conflict with a space-separated package script name that, although it is valid JSON, will not run when using "npm run xxx".

coveralls commented 7 years ago

Coverage increased (+4.6%) to 100.0% when pulling 36f22d7010af8995e6251611e637bd0b57649b6c on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage increased (+4.6%) to 100.0% when pulling 49e0de777af094713e8c22008a348d0ab2346d1b on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage increased (+4.6%) to 100.0% when pulling 49e0de777af094713e8c22008a348d0ab2346d1b on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage increased (+4.6%) to 100.0% when pulling 49e0de777af094713e8c22008a348d0ab2346d1b on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage increased (+4.6%) to 100.0% when pulling 49e0de777af094713e8c22008a348d0ab2346d1b on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage decreased (-0.7%) to 94.667% when pulling 6a77a98c9cefdfb2ca13004b24c2ccebdf5693a2 on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 94.805% when pulling e2fbc4880cd2139e4728d1c44f0c696fd8ee4457 on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 94.805% when pulling e2fbc4880cd2139e4728d1c44f0c696fd8ee4457 on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 94.805% when pulling e2fbc4880cd2139e4728d1c44f0c696fd8ee4457 on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 94.805% when pulling 5d98c46546658473e82c6b04732a47cb833fe304 on FabianMeul:master into f55b66b9c75b73a903f5b77c7c511a13e0c7edff on observing:master.

FabianMeul commented 7 years ago

Is support for node 0.10 really necessary...? There seems to be a dependency of spawn-sync that sets "thread-sleep": "*" as a dependency. This module has "engines": { "node": ">=0.11.12" } as a requirement.

So just dropping support for node 0.10 (which is pretty old by now...) should make the travis-ci tests succeed again.