search

observing / thor

The WebSocket god of thunder
MIT License
1.29k stars 154 forks source link

ws.git is not found #41

Open srpelissier opened 7 years ago

srpelissier commented 7 years ago

the command npm install -g thor fails because of a missing dependency.

npm ERR! Linux 4.8.0-32-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "thor"
npm ERR! node v7.0.0
npm ERR! npm  v4.0.5
npm ERR! code 128

npm ERR! Command failed: git clone --template=/home/user/.npm/_git-remotes/_templates --mirror git://github.com/3rd-Eden/ws.git /home/user/.npm/_git-remotes/git-github-com-3rd-Eden-ws-git-2e9f11e5

the remote in question is not found on github.

serdarozturk commented 7 years ago

42 update ws git remote path.

@srpelissier If there is urgency. Fork the project and update correct ws git path on package.json.

after run npm install -g srpelissier/thor

or run my forked git repo

npm install -g serdarozturk/thor

srpelissier commented 7 years ago

Is not urgent. I see your fix, but should I not wait for upstream to be green before closing?

rszalski commented 7 years ago

This is also duplicated by #45 where I commented that a "fix" already in the main repo. Note that https://github.com/einaros/ws might differ from https://github.com/websockets/ws.