search

obsidian-community / obsidian-full-calendar

Keep events and manage your calendar alongside all your other notes in your Obsidian Vault.
https://davish.github.io/obsidian-full-calendar/
MIT License
787 stars 105 forks source link

Fix timezones in ICS calendars #540

Open ArenSH opened 8 months ago

ArenSH commented 8 months ago

Overview

This PR fixes issue with incorrect time for ICS events:

Related Issues

Related PRs

Kartbllansh commented 7 months ago

How can this PR be utilized?

ArenSH commented 7 months ago

@Kartbllansh I'm not sure what you mean :). When the request is merged and a new version of the plugin is published - you'll have proper timezones in your ICS events.

Alternatively, you can clone the branch with the fix, build the plugin and replace <obsidian plugins>/obsidian-full-calendar/main.js file.

Kartbllansh commented 7 months ago

@Kartbllansh I'm not sure what you mean :). When the request is merged and a new version of the plugin is published - you'll have proper timezones in your ICS events.

Alternatively, you can clone the branch with the fix, build the plugin and replace <obsidian plugins>/obsidian-full-calendar/main.js file.

Thanks for the reply! I just cloned the branch, but I can't figure out how to build the plugin? Can you give me a hint on how it can be done?

ArenSH commented 7 months ago

@Kartbllansh Sure,

It will generate main.js and main.css files in the project's root. Replace <obsidian plugins>/obsidian-full-calendar/main.js file with the generated one - thats it.

ArenSH commented 7 months ago

Hi @davish

Can you please take a look at this request? Please let me know if anything needs to be adjusted.

Kartbllansh commented 7 months ago

Hi @davish

Can you please take a look at this request? Please let me know if anything needs to be adjusted.

I've been off the grid for the last few days. Yesterday I tried to do everything according to your instructions and I failed.

  1. I may have made a mistake somewhere during compilation, because it didn't work at all the first time.
  2. If you consider that everything is correct, then main.css breaks the display in the form of a table at all. If you change only js and manifest, the problem with time display remains.