Page embed in Tasks Broken by pluggin (reading mode)

[William-A-A]

Please check that this issue hasn't been reported before.

• [X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior

When embedding a Page in a task, the embedded content should be shown on the page. This should happen in both Reading and Editing modes.

Here is what it looks like in Edit mode :

Here is what it looks like in Reading mode :

Current behaviour

The embedded page content (when embedded in a task) is not shown in reading mode. See the following image

We could "think" that an easy workaround is to stay in edit mode, but even that is not completelly possible as if you nest multiple embedded content the first one is shown but the second one is not (since the first embedded content is treated as beeing in "reading mode". This issue is (weirdly enought) harder to reproduce Here is an example :

With Task pluggin (Edit mode) : (Content of Test 3 is shown but not the content of P1)

Without Task pluggin : Edit mode :

Reading mode :

Steps to reproduce

Edit: see this comment below for detailed steps: https://github.com/obsidian-tasks-group/obsidian-tasks/issues/1877#issuecomment-1510329800

Original steps commented out here...

Which Operating Systems are you using?

• [ ] Android
• [ ] iPhone/iPad
• [ ] Linux
• [ ] macOS
• [X] Windows

Obsidian Version

0.15.9 (installer) , v1.1.16 (obsidian)

Tasks Plugin Version

3.1.0

Checks

• [X] I have tried it with all other plugins disabled and the error still occurs

Possible solution

Sorry no idea why :( :(

[claremacrae]

Thank you for the request, but it is not something that I can currently test in a reasonable amount of time.

Please read this page thoroughly:

https://publish.obsidian.md/tasks/Support+and+Help/Report+a+Bug

The relevant page of documentation to read for this issue will be:

https://publish.obsidian.md/tasks/Getting+Started/Getting+Started

And then supply reproduction steps with text that whoever might work on this can copy for testing. Thank you.

[William-A-A]

Hello, sorry for the lack of info. Here are the exact steps to reproduce :

Setup

1. Create a new vault and install Tasks plugin

2. Make sure that the option "Default editing mode" is set to "Live Preview" in Settings>Editor

3. Create a file called Delete me - Issue 1877 - 01

4. Paste the following content in the created file: Delete me - Issue 1877 - 01

   This is file 01 Content
   - [ ] 01 Hello
   - [ ] 01 How are you
   - [ ] 01 All good

5. Create a file called Delete me - Issue 1877 - 02

6. Paste the following content in the created file: Delete me - Issue 1877 - 02

   This is file 02 Content
   - [ ] 02 Hello
   - [ ] 02 How are you ![[Delete me - Issue 1877 - 01]]
   - [ ] 02 All good

7. Create a file called Delete me - Issue 1877 - 03

8. Paste the following content in the created file: Delete me - Issue 1877 - 03

   This is file 03 Content
   - [ ] 03 Hello
   - [ ] 03 How are you 
   - [ ] 03 All good ![[Delete me - Issue 1877 - 02]]

Primary Bug reproduction: Embedded content not showing in Reading view

1. Open file Delete me - Issue 1877 - 02
2. Switch to Reading mode and verify that the file Delete me - Issue 1877 - 01 embedded content is not showing

Bug reproduction (Reading mode with Tasks plugin):

Desired result (Reading mode without Tasks plugin):

Secondary Bug reproduction: consequence of the primary bug in Live preview

Note: When embedding a file, the "content" of that file is always displayed in "Reading mode".

1. Open file Delete me - Issue 1877 - 03
2. Switch to "Live preview" mode. Note: Remember that this file embeds the file Delete me - Issue 1877 - 02, and Delete me - Issue 1877 - 02 embeds the file Delete me - Issue 1877 - 01 .
3. Verify that the embedded content of file Delete me - Issue 1877 - 01 is not showing in Live preview mode

Bug reproduction (Live preview mode with Tasks plugin) :

Desired result (Live preview mode without Tasks plugin) :

Hope this was better, thanks a lot for your work <3

[claremacrae]

Hi @William-A-A - that's a tremendous improvement.

I've commented out the original 'Steps to reproduce' above and added a link to your new comment.

One or more developers may be going through those steps multiple times, so can I ask you to please kindly edit a couple more things to clarify the above...

• Where you say 'Editing mode' there are actually two editing modes.
  • From your screenshots, it looks like you are using 'Live Preview' - so please could you change 'Editing mode' to 'Live Preview' above, to make it unambiguous
• Find a way to format it so that there is a clear list of just the minimal steps that are needed to reproduce the bug
  • As well as giving the steps to reproduce the problem, there seems to be a range of other steps that are actually not to do with the reproduction - and they make the repro steps more time-consuming to go through and read through
  • Without deleting the non-bug steps, could you find a way to make it clear which bits are the bug repro, and which bits are other stuff...
  • Perhaps by adding headings to divide the long list up into sections
  • Or perhaps divide up some of into sections called Expected behaviour and actual behaviour...

[William-A-A]

Hello @claremacrae I've tried to make some improvements taking into account your feedback, hope it will help ^^. Thanks a lot for the detailed instruction. Would you like me to copy the final version in the first post to ease the reading of developers ?

[claremacrae]

That’s a lot better. I had no idea earlier that there were two different issue reproductions in there.

FYI whenever I’m looking at issues, I’m juggling with responding to other issues, reviewing and testing multiple live pull requests and thinking how document them.

Your current formatting now makes it actually feasible to look at this issue and evaluate it, with all the other cognitive load going on as well.

Thank you.

[William-A-A]

Again thanks for your instructions <3. And sorry for the added work. I'm always happy to learn and next time I'll try to get it right from the get-go :).

[William-A-A]

Hello, Are the tags "Question" and "Insufficient info" still necessary? I was wondering if it might have an impact on this bug being taken into account or not x). Have a lovely day

[claremacrae]

Apologies, I review issues with those labels every week or so, and had not got round to removing this one yet.

Now done.

I don’t know what actual label to give it though. I guess it’s not really a rendering issue, or a parsing one. So I’m stuck.

[William-A-A]

Thanks for the update ^^. On the label I sadly cannot help you :(.

[claremacrae]

I have created a label display: reading mode...