obsidian-tasks-group / obsidian-tasks

Task management for the Obsidian knowledge base.
https://publish.obsidian.md/tasks/
MIT License
2.39k stars 225 forks source link

Edit Task modal: creating a task with both Cancelled and Done is possible #2986

Open ilandikov opened 1 month ago

ilandikov commented 1 month ago

Please check that this issue hasn't been reported before.

Expected Behavior

The Modal should not let create a task with both Cancelled and Done dates set - the Apply button should not be accessible

Current behaviour

The Apply button is normal and a task with Cancelled and Done date is created

Steps to reproduce

Which Operating Systems are you using?

Obsidian Version

1.6.7

Tasks Plugin Version

7.6.0

Checks

Possible solution

Make the Modal disable the Apply button when both Done and Cancelled date are present.

I have a compact one-line fix for this but, is it testable only manually due to the architecture of our modal. An improvement on that matter can be made, but that is another topic.

claremacrae commented 1 month ago

Good spot...