Upgrade confluent kafka go to 1.4.2

obsidiandynamics / goharvest

Transactional outbox harvester for Postgres → Kafka, written in Go

BSD 3-Clause "New" or "Revised" License

184 stars 18 forks source link

Upgrade confluent kafka go to 1.4.2 #2

Closed B3rs closed 3 years ago

B3rs commented 3 years ago

Upgrade confluent kafka go to v1.4.2. Sadly looks like internally confluent kafka go imports

github.com/confluentinc/confluent-kafka-go

so it results indirectly imported

I could not upgrade to librdkafka 1.5.2 because integration tests are not passing anymore (i suspect a problem in goneli)

resolves #1

milan-mnf commented 3 years ago

@B3rs, I've just made some changes. Can you please try v0.3.1 and let me know how you go?

B3rs commented 3 years ago

@milan-mnf sure! i'll close the pr since it's useless now :) could you help me understand why it tests are failing? looks like the topic creation is broken but couldn't figure out why