search

obsidiandynamics / kafdrop

Kafka Web UI
Apache License 2.0
5.45k stars 833 forks source link

try to fix "Add chart-release actions workflow #630" by using charts_… #631

Closed florianbachmann closed 5 months ago

florianbachmann commented 5 months ago

…dir: chart

This PR tries to use the charts_dir directive, because in this repo the name is chart instead of the default charts.

Related: https://github.com/obsidiandynamics/kafdrop/issues/236, https://github.com/obsidiandynamics/kafdrop/issues/357, https://github.com/obsidiandynamics/kafdrop/issues/360

Bert-R commented 5 months ago

Now it failed as follows:

Looking up latest tag...
Discovering changed charts since '4.0.1'...
WARNING: chart/templates/Chart.yaml is missing, assuming that 'chart/templates' is not a Helm chart. Skipping.
Nothing to do. No chart changes detected.

I'm afraid this is not going to work. See helm/chart-releaser-action#87 and helm/chart-releaser-action#132.

Bert-R commented 5 months ago

@florianbachmann / @FieteO: Ideas how to get this fixed? If not, I take it out again.

FieteO commented 5 months ago

Wee could try to move the chart into the subfolder. I can do that in the next days if none of you want to try it

Bert-R commented 5 months ago

That is not going to fix it. The action is not created for a source code repository that also contains a chart. See this comment. I'm going to remove the work flow.

QuinnBast commented 2 months ago

Very sad :(

Would love to see your chart in a public repository as our main workflows for deployment rely on this... We have to maintain a custom fork specifically to host your chart in a local helm repository