Open SashaKryzh opened 1 week ago
Should I create a PR to update the docs?
Should I create a PR to update the docs?
It would be helpful if you could at least get the foundations started. Joethei just go back from vacation and is catching up on plugin reviews, and my focus is on the main help docs for this week at least. :)
Should I create a PR to update the docs?
It would be helpful if you could at least get the foundations started. Joethei just go back from vacation and is catching up on plugin reviews, and my focus is on the main help docs for this week at least. :)
I created a PR that addresses "Build a plugin" and "Manifest" pages. I think it would be good to also add this info to onExternalSettingsChange
documentation.
Should I create a PR to update the docs?
It would be helpful if you could at least get the foundations started. Joethei just go back from vacation and is catching up on plugin reviews, and my focus is on the main help docs for this week at least. :)
I created a PR that addresses "Build a plugin" and "Manifest" pages. I think it would be good to also add this info to
onExternalSettingsChange
documentation.
To confirm, this is roughly the part that you think should be added to onExternalSettingsChange
?
[!note] For local development, the
id
should match the plugin's folder name; otherwise some methods, such asonExternalSettingsChange
, won't be called.
To confirm, this is roughly the part that you think should be added to
onExternalSettingsChange
?Note
For local development, the
id
should match the plugin's folder name; otherwise some methods, such asonExternalSettingsChange
, won't be called.
Yes. When it didn’t work for me, the first page I opened was the onExternalSettingsChange
documentation.
Maybe something like this: For local development, the id
in the manifest.json
should match the plugin's folder name; otherwise, this method won't be called.
Got it, I'll add it to my batch of changes this evening as your PR was already merged. :)
Edit: Joethei will handle this actually and get something added. <3
For Obsidian to work correctly, the folder name in
.obsidian/plugins
must match theid
inmanifest.json
. Without this, methods such asonExternalSettingsChange
won't be called. However, this requirement isn't mentioned anywhere in the Obsidian documentation (neither on the Manifest page nor the onExternalSettingsChange page).Why this is a problem:
id
. So, if such a repository is cloned,onExternalSettingsChange
won't work.onExternalSettingsChange
don't work (Discord question).Solutions:
onExternalSettingsChange
pages.