search

obsidianmd / obsidian-help

Help documentation for Obsidian.
https://help.obsidian.md
1.11k stars 354 forks source link

The vault icon has wrong color in dark mode #662

Closed TheOne04 closed 8 months ago

TheOne04 commented 8 months ago

The vault icon stays dark even in dark mode unlike the other icons: image

Page referenced: https://help.obsidian.md/User+interface/Ribbon#Actions

It is probably because of this line: https://github.com/obsidianmd/obsidian-help/blob/6887334b32b663d8c869affaa5de149afb565dbf/en/publish.css#L10

Because the vault icon is an obsidian icon and not one from lucide.

I was thinking of making a PR with something like this:

.theme-dark img[src*="lucide"], img[src*="obsidian-vault"] {

but thought this might not be the best way to do it.

TheOne04 commented 8 months ago

It's not just the vault icon, I came across another icon i.e. "obsidian-side-bar-left" that has the same issue: image

Page referenced: https://help.obsidian.md/User+interface/Sidebar

Probably icons like these should be renamed to add a common prefix?

sigrunixia commented 8 months ago

This should now be fixed. :)

I-Pch commented 8 months ago

I'm sorry but I've got to ask 😇 : Would the change here have some side-effects on Obsidian's Logo and the website's title colors at the top ? 😊

I just filed a BR on the forum regarding this: https://forum.obsidian.md/t/obsidian-help-website-small-visual-bug-logo-and-title-in-dark-mode/76501

(I wasn't sure where to submit it 😊 )

sigrunixia commented 8 months ago

It did. I didn’t realize that our logos and titles had the same naming conventions. A bad oversight on my part, really.

I will rename the icons and further scope the CSS today, and that should fix it.