search

obsidianmd / obsidian-help

Help documentation for Obsidian.
https://help.obsidian.md
1.1k stars 346 forks source link

Lucide font instead of icons #751

Closed mdSlash closed 3 months ago

mdSlash commented 3 months ago

Hi there! Could we use the Lucide font in the docs instead of icons? The font is available at https://github.com/iconicFonts/if/tree/main/packs/Lucide. I've tried the font inside Obsidian, and the result is as shown in the following image:

image

sigrunixia commented 3 months ago

Any particular reason why you suggest using a font for this? Keep in mind that fonts will need to be embedded in the publish.css, and add slowness to the site. Whereas individual SVG's are quite fast.

mdSlash commented 3 months ago

Any particular reason why you suggest using a font for this? Keep in mind that fonts will need to be embedded in the publish.css, and add slowness to the site. Whereas individual SVG's are quite fast.

I thought it would be easier to just insert the icons as glyphs instead of images, because it's like adjusting font color and size without needing extra CSS.

sigrunixia commented 3 months ago

The benefit of the SVG images is that we can only include what images we need. Whereas embedding the font, unless you pick it apart or encode your own version of the font, is going to include data that we will not need, which will bloat the publish.css since we have to base64 encode the font.

As we have both custom icons and lucide icons, the images will stay for now. We can always re-evaluate down the line.