search

obsidiansystems / ledger-app-nervos

MIT License
10 stars 10 forks source link

Remove chain_code from priv #136

Closed dfordivam closed 4 years ago

dfordivam commented 4 years ago

Saves 32 bytes, contains #135

dfordivam commented 4 years ago

There are now 4 failures with debug enabled, all are negative tests

 ✗ Signing with more than five output to distinct destinations rejects.
   (from function `rejectionMessageCheck' in file ./tests/lib.sh, line 108,
    in test file tests/multi-output-signing.bats, line 38)
     `rejectionMessageCheck "Can't handle more than five outputs"' failed
 ✗ Signing with strict checking of a transaction having a type script fails
   (from function `rejectionMessageCheck' in file ./tests/lib.sh, line 108,
    in test file tests/signing.bats, line 466)
     `rejectionMessageCheck "Only the DAO type script is supported" 2' failed
 ✗ Signing with strict checking, a plain transfer, and data in an output cell fails
   (from function `rejectionMessageCheck' in file ./tests/lib.sh, line 108,
    in test file tests/signing.bats, line 508)
     `rejectionMessageCheck "Data found in non-dao cell"' failed
 ✗ Signing with strict checking, a plain transfer, and data in an output cell fails even with eight bytes of data
   (from function `rejectionMessageCheck' in file ./tests/lib.sh, line 108,
    in test file tests/signing.bats, line 515)
     `rejectionMessageCheck "Data found in non-dao cell"' failed
dfordivam commented 4 years ago

The failures got resolved after clean build