Closed katat closed 4 years ago
That would imply that it's signing just a witness, somehow, rather than signing the whole transaction and producing a witness. In general you need to sign the same transaction multiple times even if this looped over all the keys available from the ledger, you might have a mix of inputs from the ledger keys and not from the ledger keys, or indeed from completely separate individuals.
Make senses to me
as per https://github.com/obsidiansystems/ledger-app-nervos/issues/145#issuecomment-672887250
The function of
signTransaction
is intended to sign a witness instead of a whole transaction. If so, it would be better to rename thesignTransaction
tosignWitnesses
to avoid confusions.signTransaction
seems implying it only needs to sign once for a transaction. But in reality, it is likely to do multiple times for a transaction under the context of HD wallet.