search

obsidiansystems / ledger-app-nervos

MIT License
10 stars 10 forks source link

Update logo for nervos app #203

Closed katat closed 3 years ago

katat commented 3 years ago

Hi there,

Since Nervos has updated its suite of logos, including the CKB symbol logo, we will need to update the logo of the ledger as well. The attached zip file contains the updated logos.

I had a try to update the icons in this folder and install the update app following the instruction on ubuntu 20.04.1, but the build/install command ./nix/install.sh -t s is not able to go beyond as the screenshot shown below:

Screen Shot 2020-12-28 at 2 20 16 PM

Without being able to verify it on my own device, I am not sure if simply replacing the icons in the folder works. Would you please help take a look at this and update the new logo onto Ledger?

Nervos icons for Ledger.zip

ApolloUnicorn commented 3 years ago

@katat are you working from a branch that we can look at?

katat commented 3 years ago

Hi @ApolloUnicorn

Here is a PR to update the icons https://github.com/obsidiansystems/ledger-app-nervos/pull/204 But I haven't been able to verify if it works. Appreciated if you can help take a look.

Thanks

ApolloUnicorn commented 3 years ago

@katat our QA team was able to load the app from that commit (pulling from your repo actually). It loaded on the device and I'm including a paste of the output. Unfortunately the logo did not come across the way I guessing you would like. I've noticed that the nano-s-logo.gif changed from 16x16 pixels to 14x14 pixels. It's possible this is the cause.

https://pastebin.com/t8Txakvh

Nervos IMG_5040

ApolloUnicorn commented 3 years ago

For context, the Nano X logo is showing correctly. That one should remain unchanged. image

katat commented 3 years ago

Thanks @ApolloUnicorn I have updated the icon of nano s to 16px and the PR to target the develop branch.

ApolloUnicorn commented 3 years ago

@katat I can't push commits because of repo access. Could you please add this logo as the nano-s-nervos.gif? When I looked at the pixel level preview of your last commit it showed gradients which the app cannot process.

ApolloUnicorn commented 3 years ago

nano-s-nervos.gif

ApolloUnicorn commented 3 years ago

Documenting the before and after of my logo changes Before

Screen Shot 2021-01-05 at 12 12 57 PM Screen Shot 2021-01-05 at 12 13 48 PM

After

Screen Shot 2021-01-05 at 12 25 44 PM
katat commented 3 years ago

Awesome @ApolloUnicorn I have included this gif file you shared and pushed a new commit to the PR.

ApolloUnicorn commented 3 years ago

@katat for some reason there was still an issue so I made a new branch from my end. See results commented there. https://github.com/obsidiansystems/ledger-app-nervos/pull/205

katat commented 3 years ago

Thanks @ApolloUnicorn