obsidiansystems / nix-thunk

seamless management of source dependencies with nix
BSD 3-Clause "New" or "Revised" License
38 stars 10 forks source link

`git@githumb.com` refs transformed into `https://github.com` refs #52

Open Rosuavio opened 2 months ago

Rosuavio commented 2 months ago

When a github repo cloned using the ssh url (e.g git@github.com:user/repo) is packed and unpacked it results in a repo with a https url for the remote (e.g https://github.com/user/repo).

The use of the ssh url is an important aspect of the thunk to some users, as pushing a change to a workflow file (anything in .github/workflows) is allowed by github using an ssh url, but refused by github using an https url.

While it seems like their could be user configuration that could be done to satisfy githubs security requirements, having a repo using an ssh url (that works for everything they need with their ssh keys configured on github) change to one using an https url that could require additional configuration is problematic.

When thunks are packed and unpacked it should preserve the schema (and probably everything else) in the uri of the remote.