Difference in serving static assets and JS - Githubissues

obsidiansystems / obelisk

Functional reactive web and mobile applications, with batteries included.

https://reflex-frp.org

BSD 3-Clause "New" or "Revised" License

949 stars 104 forks source link

Difference in serving static assets and JS #881

Open dimsmol opened 2 years ago

dimsmol commented 2 years ago

Obelisk version: v0.9.1.0

I've noticed the following differences in serving static assets vs serving JS:

Static files are referenced by the names with hashes, e.g. 1sjgs70sb2mpmx4k6608n42f0d1y5xxyaf7f4pl5hl961xzjzy7n-main.css
JS is referenced by the name without hash, e.g. all.js and that route redirects to the name with hash, adding an extra round trip
Also, static assets are served correctly if backend started from the wrong directory (e.g. if ran test-app/backend instead of cd test-app && ./backend) while JS routes respond with 404 in that case

Related questions:

What is the reason for referencing all.js without hash and making a redirect?
Is it possible to serve JS properly if started in a wrong directory? (I guess yes since static assets are ok in that case)
- Or maybe it's better to fail on start if expected directories cannot be found? (the current half-working state in that case is pretty confusing)

madeline-os commented 2 years ago

all.js is served without hash because it predates the hashing mechanism we use for assets. That said, we can definitely improve the logic by having the page supply the hashed version.

As for the JS assets issue, that is definitely a bug-like condition, so we will look into it. Apologies for the long delay in response.