support for binary data color extraction (extract from downloaded image)

obskyr / colorgram.py

A Python module for extracting colors from images. Get a palette of any picture!

MIT License

451 stars 50 forks source link

support for binary data color extraction (extract from downloaded image) #9

Closed nleroy917 closed 4 years ago

nleroy917 commented 4 years ago

Same motivation and concept as before, with following changes:

Removed references to URL - abstracted to refer only to binary data,
squashed to one commit
changed test_api.py to test binary data with locally downloaded image rather than one downloaded during testing

obskyr commented 4 years ago

Perfect! Very very nice! I'll merge this and push it to PYPI when I have a moment. Thank you very much for the contribution! 😊

nleroy917 commented 4 years ago

No problem! Thanks for reviewing considering it!

nleroy917 commented 4 years ago

Hey - just checking in on the status of this PR

obskyr commented 4 years ago

Oh no, I just realized that this is a breaking change. On Python 2, str is bytes, and paths are often supplied in that type – so this PR may break existing Python 2 code that uses colorgram.py. I'm sorry – this can't be added to the API without breaking anything… I'd recommend using BytesIO user-side when invoking colorgram.py!

nleroy917 commented 4 years ago

Makes sense - thanks for the consideration