search

obsolescence / pidp10

PiDP-10 system software package
26 stars 6 forks source link

There are 18 column bits #23

Open stevefalco opened 4 months ago

stevefalco commented 4 months ago

There appears to be a typo where ka10_pipanel.c only initializes 10 column bits. This should be 18.

rcornwell commented 4 months ago

Good catch, let me fix this in master sources and push it with current pending PR.

stevefalco commented 4 months ago

Is the master source your sims project at https://github.com/rcornwell/sims? I also submitted it there:

https://github.com/rcornwell/sims/pull/322

I'm having a hard time following which is the authoritative code. :-) I guess it could also be https://github.com/open-simh/simh - I didn't submit there...

rcornwell commented 4 months ago

Yes, I already added the patch and pushed it out.

Mikea44 commented 2 months ago

I just chased this down also. The fix went in 2 months ago. The binaries here are 5 months old and don't have the fix. The binary here will work if you run scansw10 first since it sets up the GPIOs that ka10_pipanel.c missed.