plugin: Use AGS to verify driver version

obsproject / obs-amd-encoder

AMD Advanced Media Framework Encoder Plugin for Open Broadcaster Studio

https://obsproject.com/forum/threads/amd-advanced-media-framework-encoder-plugin-for-obs-studio.52305/

GNU General Public License v2.0

454 stars 87 forks source link

plugin: Use AGS to verify driver version #382

Closed jpark37 closed 4 years ago

jpark37 commented 4 years ago

Description

Use AGS to verify driver version.

Motivation and Context

Hopefully, this will prevent AMF from having the chance to crash.

How Has This Been Tested?

Breakpoint inspection. Successful run against Vega.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.

jpark37 commented 4 years ago

Starting in draft status. The code change is fairly straightforward, but I don't know where best to put the AGS files and license text. I also don't want to submit AGS underneath this plugin in case OBS will want to use it directly for some reason.

Xaymar commented 4 years ago

See comment here. There is already a driver version check in place, though it uses the AMF runtime for it.

jpark37 commented 4 years ago

I think https://github.com/Xaymar/obs-amd-encoder/commit/7225ecd8df02fc7267f004429e40015cdb5d2a91 is fine, but I'd prefer AMF_FULL_VERSION to keep the version check up-to-date.