H264, H265: Update VIDEO_CS_DEFAULT to 709 - Githubissues

obsproject / obs-amd-encoder

AMD Advanced Media Framework Encoder Plugin for Open Broadcaster Studio

https://obsproject.com/forum/threads/amd-advanced-media-framework-encoder-plugin-for-obs-studio.52305/

GNU General Public License v2.0

454 stars 87 forks source link

H264, H265: Update VIDEO_CS_DEFAULT to 709 #405

Closed jpark37 closed 4 years ago

jpark37 commented 4 years ago

Description

H264, H265: Update VIDEO_CS_DEFAULT to 709

See main application PR: https://github.com/obsproject/obs-studio/pull/3415

Motivation and Context

Color space consistency.

How Has This Been Tested?

Debugger inspection of all changes. It doesn't seem like we ever pass VIDEO_CS_DEFAULT because the UI setting only has sRGB, 709 and 601.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

jpark37 commented 4 years ago

Changes have been tested although we don'l actually seem to use VIDEO_CS_DEFAULT.