Open WizardCM opened 3 years ago
Few things:
.format
/f-strings) insteadRESET
part4) did cross my mind as I went to bed. Definitely worth fixing. I'll get all 4 points fixed this week.
Alright, I removed formatting entirely & ensured it doesn't affect log files. Let me know if it needs anything else.
Well this is a bit of an issue. I wonder if there's a cross-platform way to do this.
Hmm, this is a good point. I don't feel particularly comfortable importing a dependency just to colour logs. I'll do some further digging. Do we want to support cmd
on Windows 10 as the minimum?
Yeah, somewhat selfishly since I do most of my work on windows, so it should work there. Haven't tested in powershell, but no sane person uses powershell.
I don't feel particularly comfortable importing a dependency just to colour logs.
The bot is already using third party requirements (requirements.txt), so I don't see why it would be a bad thing. I personally believe that it's better to depend a package that results in more readable code than it is to try to build in that functionality myself in situations like this.
After a few minutes of using the bot, I realised it'd benefit from some basic colour coding for logging levels.