Update CMakeLists for modern builds - Githubissues

obsproject / obs-browser

CEF-based OBS Studio browser plugin

GNU General Public License v2.0

777 stars 221 forks source link

Update CMakeLists for modern builds #290

Closed PatTheMav closed 2 years ago

PatTheMav commented 3 years ago

Description

Updates CMake build script to coincide with changes in https://github.com/obsproject/obs-studio/pull/4560. Header definitions have been changed in source files appropriately.

Motivation and Context

Updates CMake build scripts last updated 7 years ago and improves build situation on macOS.

How Has This Been Tested?

Full OBS builds on macOS, Linux, and Windows

Types of changes

Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

tytan652 commented 3 years ago

I think you forgot to change the formatcode.sh of this repo

PatTheMav commented 3 years ago

Good catch - see my comment here: https://github.com/obsproject/obs-vst/pull/85#issuecomment-856917956

PatTheMav commented 3 years ago

@dodgepong As this is a companion PR to https://github.com/obsproject/obs-studio/pull/4560, should make sense to add it this PR and https://github.com/obsproject/obs-vst/pull/85 to the OBS 28 project as well.