obsproject / obs-browser

CEF-based OBS Studio browser plugin
GNU General Public License v2.0
776 stars 220 forks source link

Not compilable against newer versions of CEF #298

Closed JoshStrobl closed 3 years ago

JoshStrobl commented 3 years ago

Operating System Info

Other

Other OS

Solus (Linux)

OBS Studio Version

27.0.1

OBS Studio Version (Other)

No response

OBS Studio Log URL

Not Applicable

OBS Studio Crash Log URL

No response

Expected Behavior

obs-browser in obs-studio 27.0.1 be compilable against CEF 91+

Current Behavior

Compilation error due to removed web_security per https://bitbucket.org/chromiumembedded/cef/issues/3058/remove-cefbrowsersettingsweb_security

/home/build/YPKG/root/obs-studio/build/obs-studio.git/plugins/obs-browser/obs-browser-source.cpp: In lambda function:
/home/build/YPKG/root/obs-studio/build/obs-studio.git/plugins/obs-browser/obs-browser-source.cpp:184:23: error: ‘CefBrowserSettings’ {aka ‘class CefStructBase<CefBrowserSettingsTraits>’} has no member named ‘web_security’
  184 |    cefBrowserSettings.web_security = STATE_DISABLED;

Steps to Reproduce

  1. Compile latest cef-minimal (e.g. 91.1.16/17) from https://cef-builds.spotifycdn.com/index.html
  2. Compile obs-studio 27.0.1 against new cef-minimal
  3. See FTBFS.

Anything else we should know?

No response

WizardCM commented 3 years ago

Correct, we officially support 75, 85 and 87 at the moment. These can be found on the Spotify CEF CDN.

There's already a PR for another change related to 91 at #297.

Feel free to submit a PR to use the --disable-web-security command line flag rather than cefBrowserSettings.web_security.