Set window title for web popups using X11 (on Linux)

WizardCM commented 3 years ago

Description

This modifies the window title of a popup generated by a browser embed/panel based on the name of the webpage.

I'm PR'ing this to get a second opinion on the implementation because Linux is not my forte and I'd rather not break anything. If no complains come up, I'll merge this in time for 27.1.

Motivation and Context

Feature parity.

How Has This Been Tested?

Connect a Twitch account and enable FFZ chat integration.
In the Chat dock, select the gear, choose "Non-Mod Settings" and then select "FrankerFaceZ Control Center"
Notice the new popup now correctly has the title "Twitch" rather than a blank name

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

derrod commented 2 years ago

Does this also work on Wayland?

WizardCM commented 2 years ago

I'm personally unsure and have no way to test. It's the primary reason I haven't merged this myself yet.

GeorgesStavracas commented 2 years ago

Does this also work on Wayland?

This is specific to browser docks, which are disabled on Wayland - so much so that there already is other X11-specific code in there.

obsproject / obs-browser