search

obsproject / obs-browser

CEF-based OBS Studio browser plugin
GNU General Public License v2.0
776 stars 220 forks source link

Automatically fetch CEF #313

Closed mbrunnen closed 2 years ago

mbrunnen commented 3 years ago

When on Linux (UNIX AND NOT APPLE) and CEF_ROOT_DIR is not set, this change will try to download CEF with cmake's FetchContent. I tried successfully a build on Debian GNU/Linux 10 (buster) with fetching CEF.

WizardCM commented 3 years ago

Please fill out the PR template.

tytan652 commented 3 years ago

Also at least check for x86_64 architecture before trying to fetch

WizardCM commented 3 years ago

I personally like this idea as a way to lower the barrier for building on Linux.

I do worry that it's yet another place to update dependency URLs when we update dependencies.

derrod commented 3 years ago

This should probably not be enabled by default.

mbrunnen commented 2 years ago

It is not enabled per default, only when CEF_ROOT_DIR is not set, while trying to build the browser function.

Yes x86_64 should be definitely checked.

Handling the URL (and hash) is a good point, where would these be?

mbrunnen commented 2 years ago

Please fill out the PR template.

Will do

jp9000 commented 2 years ago

Hi there, we'd prefer not to do this for now. But thank you very much in either case.

mbrunnen commented 2 years ago

ok, your loss ;)