search

obsproject / obs-browser

CEF-based OBS Studio browser plugin
GNU General Public License v2.0
776 stars 220 forks source link

Remove CLang formatting errors #324

Closed dykstrap closed 2 years ago

dykstrap commented 2 years ago

Description

Commenting out the commands that run our formatting checks. OBS-Project doesn't seem to be following them and I'd like to be consistent with their codebase so we can pull changes they make.

Motivation and Context

If we're not going to follow or fix these warning, I'd rather not see a bunch of failed tasks. My thoughts are we either fix them or turn them off. They're commented out so if we change our minds, someone knows how to turn them back on.

Any errors we have potentially hide important issues we should be fixing. Builds should always be green and it it should be the highest high priority to fix a "failing" build when other people are working on it. Since these are unimportant (ie, no one is doing anything about them and it literally takes one cocomand for the whole repository,

derrod commented 2 years ago

Seems like you submitted this to the wrong repo.

dykstrap commented 2 years ago

Yes, sorry.