Log cef version in cmake & fix debug builds for cef >= 4430 on MSVC

pkviet commented 2 years ago

Description

SInce this cef commit [1] (cef >= 4430 on windows), iterator debugging was disabled for cef_sandbox. This prevents debug builds for obs-browser and obs-browser-page projects with MSVC. The issue does not arise on other platforms. The 2nd commit adds the correct preprocessor definition allowing building for obs-browser and obs-browser-page projects when not using browser_legacy (I.e. cef 4638+ rather than cef 3770). The first commit retrieves cef version, which allows a version comparison in the 2nd commit.

[1] https://bitbucket.org/chromiumembedded/cef/commits/f2f0bfbdb5a46be8fe99341abf3aaae744573edc

Motivation and Context

Motivation: we want to be able to debug obs-browser ...

How Has This Been Tested?

This has been tested by building obs-studio with obs-browser and obs-browser-page with cef 4638. It builds fine.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

WizardCM commented 2 years ago

When I tried to make this code change myself, aja failed to build. Could you confirm with aja deps, it all builds correctly?

pkviet commented 2 years ago

When I tried to make this code change myself, aja failed to build. Could you confirm with aja deps, it all builds correctly?

aja builds corectly

pkviet commented 2 years ago

Updated the PR:

logs cef version;
compares cef version against 4430 in order to enable (or not) the preprocessor definition _ITERATOR_DEBUG_LEVEL=0 .

RytoEX commented 2 years ago

When I tried to make this code change myself, aja failed to build. Could you confirm with aja deps, it all builds correctly?

While we ship the debug AJA library in the old dependencies package, we do not currently ship it in the obs-deps package. I don't know if that's what you ran into here.

obsproject / obs-browser