Remove CefInitialize hack argument on Windows

jpark37 commented 2 years ago

Description

Newer CEF will behave as desired by passing nullptr.

Motivation and Context

Hack is brittle, and could regress.

How Has This Been Tested?

Verified WGC capture works with/without admin on old/new CEF.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

RytoEX commented 2 years ago

We only removed CEF version ifdefs for versions older than 3770 (75). Does this need ifdef'd to prevent bad behavior on versions in between that and 4638 (95)?

WizardCM commented 2 years ago

I would vote an ifdef for > 3770 or just wait until we update CEF again in OBS 28.0 before merging this.

RytoEX commented 2 years ago

This looks fine to me visually. I haven't tested building.

obsproject / obs-browser