Check for CEF_ROOT_DIR environment variable

cpyarger commented 2 years ago

Description

Adds a check for the CEF_ROOT_DIR environment variable, and if found uses it

Motivation and Context

Eases workload for local development

How Has This Been Tested?

Windows 10, Set Environment variable, CMake sees and uses it properly

Types of changes

Bug fix (non-breaking change which fixes an issue)
Tweak (non-breaking change to improve existing functionality)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

RytoEX commented 2 years ago

This will likely conflict with #290, and I'm not sure we should continue using un-namespaced/un-prefixed environment variables.

jp9000 commented 2 years ago

Going to close this for now because I'm not sure if we want to rely on environment variables anymore, plus we're reworking our CMake anyway. If there's a good argument for it I might consider it, although preferably after we merge the CMake overhaul.

obsproject / obs-browser