obsproject / obs-browser

CEF-based OBS Studio browser plugin
GNU General Public License v2.0
771 stars 218 forks source link

obs-browser: Ensure saved source is alive #364

Open walker-WSH opened 2 years ago

walker-WSH commented 2 years ago

Description

In browser-client, created source is saved into two lists:

std::vector<obs_source_t*> audio_sources;
std::unordered_map<int, AudioStream> audio_streams;

But there is no reference for audio_sources. I meet a crash as below:

1653896576

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

gxalpha commented 2 years ago

Is there any particular reason why you're still running a CEF older than 4103? I'm asking since we're looking to update our CEF again for the next version of OBS, in which case this code would get removed (we're usually supporting the current plus the last CEF).

walker-WSH commented 2 years ago

Is there any particular reason why you're still running a CEF older than 4103? I'm asking since we're looking to update our CEF again for the next version of OBS, in which case this code would get removed (we're usually supporting the current plus the last CEF).

since the crash in #360 , I am still using the old CEF.

that crash of obs-browser-page.exe can be reproduced easy on my PC