obsproject / obs-browser

CEF-based OBS Studio browser plugin

GNU General Public License v2.0

771 stars 218 forks source link

Avoid redefining UNUSED_PARAMETER rather than linking to libobs #370

Closed tytan652 closed 2 years ago

tytan652 commented 2 years ago

Description

368 links some binary to libobs which is something that should not be done.

Motivation and Context

I'm actually working on a PR to treat warnings as errors.

How Has This Been Tested?

The warning/error no longer appear while building OBS Studio with this PR.

Types of changes

Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.