cmake: Update CMake files for build system 3.0 update - Githubissues

obsproject / obs-browser

CEF-based OBS Studio browser plugin

GNU General Public License v2.0

769 stars 217 forks source link

cmake: Update CMake files for build system 3.0 update #394

Closed PatTheMav closed 1 year ago

PatTheMav commented 1 year ago

Description

This PR updates the CMake build files to be compatible with the build system 3.0 update on the main repository.

Motivation and Context

The current build script is retained as the "legacy" script (which will still be used to generate build projects on Linux and macOS)
The new build script is used for macOS builds by default at first

The updated build system enforces uses Xcode by default on macOS and has some stricter code requirements, which are also fixed by this PR:

Shadowing is fixed (new variables created in local scope with the same name as existing instance variables, thus shadowing them).
Implicit casts are changed to be explicit (mainly for data being passed from data types with different bit-depth) - while data loss is still possible, the casts make it explicit that the developer is aware of this possible issues and wants to ignore it.

More information shall be available in the pull request on the main repository.

Note: This PR needs to be merged first, then the associated commit hash updated for the obs-browser submodule at obs-studio.

How Has This Been Tested?

New build scripts were tested as part of the overall update on macOS 13, Ubuntu 22.10, and Windows 11.

Types of changes

Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

[x] I have read the Contributing Guidelines.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] My code is not on master or a release/* branch.
[x] The code has been tested.
[x] I have included updates to all appropriate documentation.

RytoEX commented 1 year ago

The commit messages may need to be adjusted. I don't see any changes to variable casting here. I think there were changes made to the scope after the initial draft.