Fix leak with SchemeHandlerFactory - Githubissues

obsproject / obs-browser

CEF-based OBS Studio browser plugin

GNU General Public License v2.0

769 stars 217 forks source link

Fix leak with SchemeHandlerFactory #396

Closed pkviet closed 1 year ago

pkviet commented 1 year ago

Description

This clears a BrowserSchemeHandlerFactory which caused a memory leak.

Motivation and Context

Noticed this leak when running Visual Leak Detector. This leak was introduced in 2015 in: https://github.com/obsproject/obs-browser/commit/2d898bf6acc1c66359d5f69d39428ed2c1fb9826 So it's been there forever. @_@

How Has This Been Tested?

The leak is now gone when VLD runs.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.