Closed PatTheMav closed 9 months ago
Updates the CMake build script for the submodule as a companion PR to https://github.com/obsproject/obs-studio/pull/9769.
Clean up the code and remove unnecessary build specifics.
The main breaking change of this PR is that it correctly requires the wrapper library to be built according to the official documentation for Windows:
Linking CEF dynamically (as obs-browser does) requires the use of the dynamic MSVC runtime library and also disabling the sandbox functionality.
obs-browser
(Runtime library changes on Windows have been moved to a separate PR).
Current code works around this issue by forcing the runtime library to be linked statically, a workaround which is removed by this PR.
Tested on Windows 11 with an updated wrapper library (built according to the documentation).
IIRC, this looked fine to me. The main caveat is that we would have to rebuild the Windows CEF wrapper to coincide with pulling this update into obs-studio?
Description
Updates the CMake build script for the submodule as a companion PR to https://github.com/obsproject/obs-studio/pull/9769.
Motivation and Context
Clean up the code and remove unnecessary build specifics.
The main breaking change of this PR is that it correctly requires the wrapper library to be built according to the official documentation for Windows:
Linking CEF dynamically (asobs-browser
does) requires the use of the dynamic MSVC runtime library and also disabling the sandbox functionality.(Runtime library changes on Windows have been moved to a separate PR).
Current code works around this issue by forcing the runtime library to be linked statically, a workaround which is removed by this PR.
How Has This Been Tested?
Tested on Windows 11 with an updated wrapper library (built according to the documentation).
Types of changes
Checklist: